Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-22231 Removed unused and '*' import #180

Merged
merged 1 commit into from
Apr 24, 2019
Merged

HBASE-22231 Removed unused and '*' import #180

merged 1 commit into from
Apr 24, 2019

Conversation

HorizonNet
Copy link
Contributor

Targeted for branch-2.0.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 38 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 81 new or modified test files.
_ branch-2.0 Compile Tests _
0 mvndep 10 Maven dependency ordering for branch
+1 mvninstall 227 branch-2.0 passed
+1 compile 278 branch-2.0 passed
+1 checkstyle 292 branch-2.0 passed
+1 shadedjars 320 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 508 branch-2.0 passed
+1 javadoc 198 branch-2.0 passed
_ Patch Compile Tests _
0 mvndep 17 Maven dependency ordering for patch
+1 mvninstall 226 the patch passed
+1 compile 274 the patch passed
+1 javac 274 the patch passed
+1 checkstyle 28 hbase-common: The patch generated 0 new + 11 unchanged - 3 fixed = 11 total (was 14)
-1 checkstyle 43 hbase-client: The patch generated 2 new + 209 unchanged - 19 fixed = 211 total (was 228)
+1 checkstyle 15 hbase-zookeeper: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 checkstyle 15 hbase-replication: The patch generated 0 new + 9 unchanged - 1 fixed = 9 total (was 10)
+1 checkstyle 18 hbase-procedure: The patch generated 0 new + 1 unchanged - 7 fixed = 1 total (was 8)
-1 checkstyle 94 hbase-server: The patch generated 4 new + 500 unchanged - 124 fixed = 504 total (was 624)
+1 checkstyle 25 hbase-mapreduce: The patch generated 0 new + 97 unchanged - 12 fixed = 97 total (was 109)
-1 checkstyle 28 hbase-it: The patch generated 1 new + 90 unchanged - 7 fixed = 91 total (was 97)
+1 checkstyle 21 hbase-rest: The patch generated 0 new + 15 unchanged - 3 fixed = 15 total (was 18)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 317 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 678 Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
+1 findbugs 591 the patch passed
+1 javadoc 200 the patch passed
_ Other Tests _
+1 unit 186 hbase-common in the patch passed.
+1 unit 215 hbase-client in the patch passed.
+1 unit 57 hbase-zookeeper in the patch passed.
+1 unit 20 hbase-replication in the patch passed.
+1 unit 237 hbase-procedure in the patch passed.
-1 unit 12147 hbase-server in the patch failed.
+1 unit 1397 hbase-mapreduce in the patch passed.
+1 unit 86 hbase-it in the patch passed.
+1 unit 485 hbase-rest in the patch passed.
+1 asflicense 278 The patch does not generate ASF License warnings.
19810
Reason Tests
Failed junit tests hadoop.hbase.util.TestFromClientSide3WoUnsafe
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/artifact/out/Dockerfile
GITHUB PR #180
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux ba2abe091073 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision branch-2.0 / 49a27e1
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.0-RC3
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/artifact/out/diff-checkstyle-hbase-client.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/artifact/out/diff-checkstyle-hbase-server.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/artifact/out/diff-checkstyle-hbase-it.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/testReport/
Max. process+thread count 5182 (vs. ulimit of 10000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-procedure hbase-server hbase-mapreduce hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet HorizonNet force-pushed the HBASE-22231-branch-2.0 branch from a30cef7 to 7aa3ca7 Compare April 22, 2019 19:07
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 51 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 81 new or modified test files.
_ branch-2.0 Compile Tests _
0 mvndep 8 Maven dependency ordering for branch
+1 mvninstall 170 branch-2.0 passed
+1 compile 207 branch-2.0 passed
+1 checkstyle 215 branch-2.0 passed
+1 shadedjars 247 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 395 branch-2.0 passed
+1 javadoc 164 branch-2.0 passed
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 165 the patch passed
+1 compile 226 the patch passed
+1 javac 226 the patch passed
+1 checkstyle 23 hbase-common: The patch generated 0 new + 11 unchanged - 3 fixed = 11 total (was 14)
+1 checkstyle 33 hbase-client: The patch generated 0 new + 208 unchanged - 20 fixed = 208 total (was 228)
+1 checkstyle 14 hbase-zookeeper: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 checkstyle 11 hbase-replication: The patch generated 0 new + 9 unchanged - 1 fixed = 9 total (was 10)
+1 checkstyle 15 hbase-procedure: The patch generated 0 new + 1 unchanged - 7 fixed = 1 total (was 8)
+1 checkstyle 72 hbase-server: The patch generated 0 new + 497 unchanged - 127 fixed = 497 total (was 624)
+1 checkstyle 18 hbase-mapreduce: The patch generated 0 new + 97 unchanged - 12 fixed = 97 total (was 109)
+1 checkstyle 24 hbase-it: The patch generated 0 new + 88 unchanged - 9 fixed = 88 total (was 97)
+1 checkstyle 16 hbase-rest: The patch generated 0 new + 15 unchanged - 3 fixed = 15 total (was 18)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 245 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 509 Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
+1 findbugs 456 the patch passed
+1 javadoc 157 the patch passed
_ Other Tests _
+1 unit 154 hbase-common in the patch passed.
+1 unit 186 hbase-client in the patch passed.
+1 unit 45 hbase-zookeeper in the patch passed.
+1 unit 15 hbase-replication in the patch passed.
+1 unit 205 hbase-procedure in the patch passed.
-1 unit 12104 hbase-server in the patch failed.
+1 unit 1239 hbase-mapreduce in the patch passed.
+1 unit 72 hbase-it in the patch passed.
+1 unit 396 hbase-rest in the patch passed.
+1 asflicense 230 The patch does not generate ASF License warnings.
18308
Reason Tests
Failed junit tests hadoop.hbase.client.TestAdmin1
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/2/artifact/out/Dockerfile
GITHUB PR #180
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 445276d772d3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision branch-2.0 / 49a27e1
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.0-RC3
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/2/testReport/
Max. process+thread count 5346 (vs. ulimit of 10000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-procedure hbase-server hbase-mapreduce hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving conditional on build test passing. These cleanup is great.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 57 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 81 new or modified test files.
_ branch-2.0 Compile Tests _
0 mvndep 15 Maven dependency ordering for branch
+1 mvninstall 236 branch-2.0 passed
+1 compile 282 branch-2.0 passed
+1 checkstyle 292 branch-2.0 passed
+1 shadedjars 322 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 514 branch-2.0 passed
+1 javadoc 199 branch-2.0 passed
_ Patch Compile Tests _
0 mvndep 17 Maven dependency ordering for patch
+1 mvninstall 215 the patch passed
+1 compile 275 the patch passed
+1 javac 275 the patch passed
+1 checkstyle 28 hbase-common: The patch generated 0 new + 11 unchanged - 3 fixed = 11 total (was 14)
+1 checkstyle 44 hbase-client: The patch generated 0 new + 208 unchanged - 20 fixed = 208 total (was 228)
+1 checkstyle 16 hbase-zookeeper: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 checkstyle 15 hbase-replication: The patch generated 0 new + 9 unchanged - 1 fixed = 9 total (was 10)
+1 checkstyle 19 hbase-procedure: The patch generated 0 new + 1 unchanged - 7 fixed = 1 total (was 8)
+1 checkstyle 95 hbase-server: The patch generated 0 new + 497 unchanged - 127 fixed = 497 total (was 624)
+1 checkstyle 25 hbase-mapreduce: The patch generated 0 new + 97 unchanged - 12 fixed = 97 total (was 109)
+1 checkstyle 27 hbase-it: The patch generated 0 new + 88 unchanged - 9 fixed = 88 total (was 97)
+1 checkstyle 21 hbase-rest: The patch generated 0 new + 15 unchanged - 3 fixed = 15 total (was 18)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 316 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 690 Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
+1 findbugs 597 the patch passed
+1 javadoc 199 the patch passed
_ Other Tests _
+1 unit 188 hbase-common in the patch passed.
+1 unit 225 hbase-client in the patch passed.
+1 unit 55 hbase-zookeeper in the patch passed.
+1 unit 19 hbase-replication in the patch passed.
+1 unit 236 hbase-procedure in the patch passed.
+1 unit 11324 hbase-server in the patch passed.
+1 unit 1379 hbase-mapreduce in the patch passed.
+1 unit 86 hbase-it in the patch passed.
+1 unit 479 hbase-rest in the patch passed.
+1 asflicense 285 The patch does not generate ASF License warnings.
19026
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/4/artifact/out/Dockerfile
GITHUB PR #180
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 5b031bb5c861 4.4.0-145-generic #171-Ubuntu SMP Tue Mar 26 12:43:40 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision branch-2.0 / c3f9264
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.0-RC3
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/4/testReport/
Max. process+thread count 4878 (vs. ulimit of 10000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-procedure hbase-server hbase-mapreduce hbase-it hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-180/4/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet HorizonNet merged commit ecb0fd0 into apache:branch-2.0 Apr 24, 2019
@HorizonNet HorizonNet deleted the HBASE-22231-branch-2.0 branch April 24, 2019 16:48
This was referenced Sep 23, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
This was referenced Oct 2, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Open
Merged
This was referenced Oct 10, 2023
Merged
Merged
This was referenced Feb 29, 2024
Merged
Open
Merged
Merged
Merged
This was referenced Mar 7, 2024
Merged
Merged
Closed
This was referenced Mar 20, 2024
Merged
Merged
Merged
Merged
Merged
Open
Merged
Open
Merged
This was referenced Mar 29, 2024
Merged
Merged
This was referenced Apr 5, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HorizonNet @Apache-HBase @saintstack